[ 
https://issues.apache.org/jira/browse/RATIS-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301622#comment-16301622
 ] 

Tsz Wo Nicholas Sze commented on RATIS-175:
-------------------------------------------

+1 patch looks good.

However, there was a NullPointerException in TestRaftExceptionWithNetty in [the 
qa build 
#74|https://builds.apache.org/job/PreCommit-RATIS-Build/74/testReport/junit/org.apache.ratis.netty/TestRaftExceptionWithNetty/testNotLeaderExceptionWithReconf/].
  The detail log seems missing.  I will try to reproduce it.

> RaftServerProxy should close server rpc in case instance creation fails
> -----------------------------------------------------------------------
>
>                 Key: RATIS-175
>                 URL: https://issues.apache.org/jira/browse/RATIS-175
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>         Attachments: RATIS-175.001.patch, RATIS-175.002.patch
>
>
> Currently RaftServerProxy does not close the server rpc in case its instance 
> creation fails. This leads to BindException when a RaftServerProxy instance 
> creation is reattempted in ServerImplUtils#newRaftServer.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to