[
https://issues.apache.org/jira/browse/RATIS-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405424#comment-16405424
]
Tsz Wo Nicholas Sze commented on RATIS-214:
-------------------------------------------
Thanks for the update. Some comments on the patch:
- Let's add a timeout field to RaftClientProtocolClient so that we can make it
configurable later.
{code}
// RaftClientProtocolClient.java
private final TimeDuration timeout = TimeDuration.valueOf(3,
TimeUnit.SECONDS);
{code}
- Similarly, add a timeout field to RaftServerProtocolClient.
- Add an appendWithTimeout method in RaftClientProtocolClient instead of adding
the withDeadline parameter.
- There is a RetryCacheTestUtil, let add a method for getOrCreateEntry instead
of making public.
- The test is quite clever. I cannot see how it works initially. Could you
add some comments to describe how it works?
> Support timeout using withDeadlineAfter for the blockingStub(Grpc)
> ------------------------------------------------------------------
>
> Key: RATIS-214
> URL: https://issues.apache.org/jira/browse/RATIS-214
> Project: Ratis
> Issue Type: Task
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: RATIS-214.001.patch, RATIS-214.002.patch,
> RATIS-214.003.patch
>
>
> This jira aims to add rpc request timeout for Grpc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
