[ 
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430973#comment-16430973
 ] 

Tsz Wo Nicholas Sze commented on RATIS-219:
-------------------------------------------

One quick comment:
- In GRpcLogAppender, read the rpcTimeout from properties (similar to 
maxPendingRequestsNum) so that we don't need to change ServerFactory and 
GrpcFactory.
{code}
    maxPendingRequestsNum = GrpcConfigKeys.Server.leaderOutstandingAppendsMax(
        server.getProxy().getProperties());
    pendingRequests = new ConcurrentHashMap<>();

    appendResponseHandler = new AppendLogResponseHandler();
    snapshotResponseHandler = new InstallSnapshotResponseHandler();
    this.rpcTimeout = rpcTimeout;
{code}


> Add configuration for timeout duration
> --------------------------------------
>
>                 Key: RATIS-219
>                 URL: https://issues.apache.org/jira/browse/RATIS-219
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: RATIS-219.001.patch
>
>
> We need to add configuration for setting timeout duration of requests at 
> client and server side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to