[ 
https://issues.apache.org/jira/browse/RATIS-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431954#comment-16431954
 ] 

Lokesh Jain commented on RATIS-224:
-----------------------------------

[~szetszwo] The patch looks very good to me. There is a typo in 
TimeoutScheduler#hasSchedul"a"r. +1 o.w.

> In RpcTimeout, it should shut down the scheduler if there is no tasks
> ---------------------------------------------------------------------
>
>                 Key: RATIS-224
>                 URL: https://issues.apache.org/jira/browse/RATIS-224
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Minor
>         Attachments: r224_20180410.patch
>
>
> Currently, RpcTimeout tracks the number of users.  When the number of users 
> becomes zero, it should shut down the scheduler .
> Instead of tracking users, it is better to try the number of tasks.  When the 
> number of tasks becomes zero, it should shut down the scheduler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to