[ 
https://issues.apache.org/jira/browse/RATIS-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434375#comment-16434375
 ] 

Tsz Wo Nicholas Sze commented on RATIS-219:
-------------------------------------------

Thanks.  Some nites
- requestTimeoutDuration in RaftClientProtocolClient and 
RaftServerProtocolClient should be final.
- TimeoutDuration.getDuration() was added by RATIS-224 so that we no longer 
need to get unit and then convert the duration.  i.e.
{code}
    return asyncStub.withDeadlineAfter(requestTimeoutDuration.getDuration(), 
requestTimeoutDuration.getUnit()){code}
instead of 
{code}
    TimeUnit unit = requestTimeoutDuration.getUnit();
    return asyncStub.withDeadlineAfter(requestTimeoutDuration.toInt(unit), unit)
{code}

> Add configuration for timeout duration
> --------------------------------------
>
>                 Key: RATIS-219
>                 URL: https://issues.apache.org/jira/browse/RATIS-219
>             Project: Ratis
>          Issue Type: Improvement
>            Reporter: Lokesh Jain
>            Assignee: Lokesh Jain
>            Priority: Major
>         Attachments: RATIS-219.002.patch
>
>
> We need to add configuration for setting timeout duration of requests at 
> client and server side.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to