[
https://issues.apache.org/jira/browse/RATIS-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449650#comment-16449650
]
Lokesh Jain commented on RATIS-230:
-----------------------------------
[~szetszwo] The patch looks very good to me. Below are few minor comments.
# While logging errors in RaftServerProtocolService we are mentioning the
follower id first whereas in GrpcLogAppender we first mention the leader id. I
was thinking it would be good to first mention the leader id so that it is easy
to trace the errors and know about leader changes? Also we can include some
identifier like LEADER so that we can use a string like "LEADER s0" for
searching all the logs involving LEADER s0?
# There is a blank line in RaftGrpcUtil#warn.
> Improve gRPC log messages
> -------------------------
>
> Key: RATIS-230
> URL: https://issues.apache.org/jira/browse/RATIS-230
> Project: Ratis
> Issue Type: Improvement
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: r230_20180420.patch
>
>
> In this JIRA, we propose
> - Stack trace is missing in some exception logs.
> - Change some info message to warn.
> - Check isDebugEnabled and isWarnEnabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
