[ 
https://issues.apache.org/jira/browse/RATIS-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453483#comment-16453483
 ] 

Mukul Kumar Singh commented on RATIS-231:
-----------------------------------------

Thanks for working on this patch [~szetszwo]. The patch looks good to me. Some 
minor comments.

1) Should the proxy reset be called for InstallSnapshotResponseHandler on error 
cases as well?
2) TestRaftServerWithGrpc:53: The log message should be of type error and 
should be elaborated.


> Grpc server should reconnect if there is an exception
> -----------------------------------------------------
>
>                 Key: RATIS-231
>                 URL: https://issues.apache.org/jira/browse/RATIS-231
>             Project: Ratis
>          Issue Type: Bug
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Blocker
>         Attachments: r231_20180425.patch
>
>
> In RATIS-229, we found that the leader with Grpc does not reconnect when a 
> follower restarts.  As a result, it will trigger a leader election.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to