[ 
https://issues.apache.org/jira/browse/RATIS-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589527#comment-16589527
 ] 

ASF GitHub Bot commented on RATIS-272:
--------------------------------------

Github user VladRodionov commented on a diff in the pull request:

    https://github.com/apache/incubator-ratis/pull/4#discussion_r212154701
  
    --- Diff: 
ratis-logservice/src/main/java/org/apache/ratis/logservice/api/RecordListener.java
 ---
    @@ -0,0 +1,19 @@
    +package org.apache.ratis.logservice.api;
    +
    +import java.nio.ByteBuffer;
    +import java.util.concurrent.CompletableFuture;
    +
    +/**
    + * Interface that, when registered with a {@link LogStream}, will receive 
all records written
    + * to that LogStream until it is removed.
    + */
    +public interface RecordListener {
    +
    +  /**
    +   * Processes the written record from the LogStream.
    +   *
    +   * @param record The record
    +   */
    +  CompletableFuture<Void> receiveRecord(ByteBuffer record);
    --- End diff --
    
    Again, do not break Listener contract - its synchronous. 


> Design ideal API
> ----------------
>
>                 Key: RATIS-272
>                 URL: https://issues.apache.org/jira/browse/RATIS-272
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: LogService
>            Reporter: Josh Elser
>            Priority: Major
>
> With influence from Apache DistributedLog, Kafka, and BookKeeper, design an 
> API that balances the ideal notion of what a distribute log system should 
> look like, but also considers the needs of HBase to replace a WAL.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to