[ 
https://issues.apache.org/jira/browse/RATIS-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622498#comment-16622498
 ] 

Tsz Wo Nicholas Sze commented on RATIS-265:
-------------------------------------------

[~rajeshbabu], thanks for the patch!  The approach looks good.
- TooManyPendingRequestsException sounds too specific.  How about renaming it 
to ServerBusyException, or even RetriableException?   So that the client should 
retry.
- There are some tabs in TooManyPendingRequestsException.java.  We uses 
two-space for indentation.

> Ratis Leader flow control request from raft client to avoid OOM errors
> ----------------------------------------------------------------------
>
>                 Key: RATIS-265
>                 URL: https://issues.apache.org/jira/browse/RATIS-265
>             Project: Ratis
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 0.2.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Rajeshbabu Chintaguntla
>            Priority: Blocker
>              Labels: ozone
>         Attachments: RATIS-265_wip.patch
>
>
> In scenario where there is lots of load on the Ratis leader, the leader 
> accepts and adds all the requests as pending appends into the sliding window.
> However if there are lots of pending replies in the sliding window, the 
> leader should reply with an error/exception to the client to retry the 
> command later.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to