[
https://issues.apache.org/jira/browse/RATIS-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627132#comment-16627132
]
Elek, Marton commented on RATIS-330:
------------------------------------
Thanks [~elserj] the patch overall it looks good to me.
1. minor: Can you please update the <scm> section in the pom.xml?
2. bigger:
I think the LICENSE/NOTICE files are not good, but I need more time to check
them. For example netty-all is included, so we need to copy the content of the
netty NOTICE file to our NOTICE. I can't see any NOTICE file in gson, so we
don't need to copy it. Still I am checking it...
> Ensure licensing on ratis-thirdparty is kosher
> ----------------------------------------------
>
> Key: RATIS-330
> URL: https://issues.apache.org/jira/browse/RATIS-330
> Project: Ratis
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Attachments: RATIS-330.001.patch
>
>
> Need to vet the stuff included in ratis-thirdparty to make sure we're using
> it all and that we have appropriate LICENSE and NOTICE files included for it.
> Also, need to make some steps for releasing it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
