[
https://issues.apache.org/jira/browse/RATIS-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639183#comment-16639183
]
Josh Elser commented on RATIS-279:
----------------------------------
{code:java}
+package org.apache.ratis.logservice;
+
+public class LogServiceImpl implements LogService {{code}
Should we put implementation classes into their own java package (e.g.
o.a.ratis.logservice.impl)?
{code:java}
+message LogServiceRequestProto {
+ oneof Request {
+ LogMessage logMessage = 1;
+ CreateLogRequestProto createLog = 2;
+ ListLogsRequestProto listLogs = 3;
+ GetLogRequestProto getLog = 4;
+ CloseLogRequestProto closeLog = 5;
+ GetStateRequestProto getState = 6;
+ ArchiveLogRequestProto archiveLog = 7;
+ DeleteLogRequestProto deleteLog = 8;
+ }
+{code}
If you agree with me that splitting up the DDL methods (e.g. list, create,
delete) from the DML methods (e.g. write, read), I think it would also make
sense to split up the protobuf messages too.
{code:java}
+ final CLUSTER cluster = newCluster(NUM_PEERS);
+ cluster.start();
+ RaftTestUtil.waitForLeader(cluster){code}
{code:java}
+ cluster.shutdown();{code}
Move these into Before and After annotated methods, respectively?
Overall looks good. Will need to put heads together with [~vrodionov] to make
sure we're not stepping on each other. Heading over to his patch now..
> Create administrative API for a log stream
> ------------------------------------------
>
> Key: RATIS-279
> URL: https://issues.apache.org/jira/browse/RATIS-279
> Project: Ratis
> Issue Type: Sub-task
> Components: LogService
> Reporter: Josh Elser
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
> Attachments: RATIS-279_WIP.patch, RATIS-279_v2.patch,
> RATIS-279_v3.patch, RATIS-279_v4.patch, RATIS-279_v5.patch
>
>
> We need to do basic things like:
> * List all log streams
> * Delete a log stream
> * Truncate a log stream
> This may overlap with functionality that actually should live in HBase.
> Making that distinction is part of the tasks of this issue.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
