[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645937#comment-16645937
]
Tsz Wo Nicholas Sze commented on RATIS-338:
-------------------------------------------
bq. The only thing I'm not sure about is the whether we may have a special
handling for exceptions in the reply code. I.e. if we are unable to get
information about one of few groups. How we should handler that.
This is really a good question. It seems that it may not be a good idea to
include all groups in a single reply. We have two options:
# Include all groups in a ServerInformationReply returned by
AdminProtocol.getInfo(..) as suggested in the JIRA.
# Replace AdminProtocol.getInfo(..) with two methods GroupInfoReply
getGroupInfo(..) and List<RaftGroupId> getGroupIds(..).
For #1, the getInfo(..) becomes heavy if there are many groups. If an
application only wants to get the info of a group, it still has to get all
group infos. Also, as mentioned by [~sergey.soldatov], it is troublesome to
handle the exceptions from some of the groups.
In #2, both methods are lightweight. getGroupIds(..) can return the keys from
the RaftServerProxy.ImplMap so that it won't has exception. getGroupInfo(..)
just returns the info of a group. It can throws exception if it fails.
How about we implement #2?
> ServerInformationReply should include multiple groups
> -----------------------------------------------------
>
> Key: RATIS-338
> URL: https://issues.apache.org/jira/browse/RATIS-338
> Project: Ratis
> Issue Type: Sub-task
> Components: server
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Sergey Soldatov
> Priority: Major
> Attachments: RATIS-338-v1.patch, RATIS-338-v2.patch
>
>
> ServerInformationReply currently only returns information of a particular
> group. It should return informations of all the groups.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
