[ https://issues.apache.org/jira/browse/RATIS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674883#comment-16674883 ]
Shashikant Banerjee commented on RATIS-362: ------------------------------------------- Thanks [~szetszwo], for updating the patch. The patch looks good to me. I am +1 on this. > Add a Builder for TransactionContext > ------------------------------------ > > Key: RATIS-362 > URL: https://issues.apache.org/jira/browse/RATIS-362 > Project: Ratis > Issue Type: Improvement > Components: server > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Priority: Major > Attachments: r362_20181105.patch > > > Currently, we use TransactionContextImpl constructors to create > TransactionContext objects. Howerver, TransactionContextImpl is supposed to > be internal but not a public API. It is better to add a Builder for > TransactionContext. The Builder is a public API. -- This message was sent by Atlassian JIRA (v7.6.3#76005)