[ https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694140#comment-16694140 ]
Hadoop QA commented on RATIS-352: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 4m 13s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 8s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 9s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 44s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 6s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} root: The patch generated 0 new + 50 unchanged - 3 fixed = 50 total (was 53) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 20m 33s{color} | {color:red} root in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 16s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 33m 20s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | ratis.server.simulation.TestLeaderElectionWithSimulatedRpc | | | ratis.server.simulation.TestServerRestartWithSimulatedRpc | | | ratis.grpc.TestRaftWithGrpc | | | ratis.examples.filestore.TestFileStoreWithNetty | | | ratis.examples.filestore.TestFileStoreWithGrpc | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/ratis:date2018-11-21 | | JIRA Issue | RATIS-352 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12948964/r352_20181120.patch | | Optional Tests | dupname asflicense javac javadoc unit findbugs checkstyle compile cc | | uname | Linux d47108358a96 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh | | git revision | master / 1dd3d0b | | maven | version: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T18:41:47Z) | | Default Java | 1.8.0_181 | | unit | https://builds.apache.org/job/PreCommit-RATIS-Build/547/artifact/out/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-RATIS-Build/547/testReport/ | | Max. process+thread count | 1179 (vs. ulimit of 5000) | | modules | C: ratis-proto ratis-server ratis-netty ratis-test ratis-examples U: . | | Console output | https://builds.apache.org/job/PreCommit-RATIS-Build/547/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Persist commit index in Raft log. > --------------------------------- > > Key: RATIS-352 > URL: https://issues.apache.org/jira/browse/RATIS-352 > Project: Ratis > Issue Type: Improvement > Components: server > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Priority: Major > Attachments: r352_20181106.patch, r352_20181107.patch, > r352_20181115.patch, r352_20181117.patch, r352_20181117b.patch, > r352_20181118.patch, r352_20181119.patch, r352_20181120.patch > > > Current the commit index is not persisted in the Raft log. When a server > restarts, it cannot apply its log until it has joined a Raft group. There is > no problem if there is a Raft group. > However, a server cannot recover its data when formatting a Raft group is > impossible (e.g. a majority of servers are dead). Ideally, a server can > safely apply the log up to the commit index. The JIRA is to persist the > commit index so that such recovery is possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)