[
https://issues.apache.org/jira/browse/RATIS-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827102#comment-16827102
]
Lokesh Jain commented on RATIS-497:
-----------------------------------
[~szetszwo] Thanks for working on this! The patch looks good to me. Few minor
comments.
# LeaderState#addSenders - Should we also check whether sender already exists
in the sender list?
# NIT - GrpcLogAppender and LogAppender - in the log messages pertaining to
follower we can prepend a string denoting that its a follower related message.
# NIT - GrpcLogAppender:277 in the Log message we can change Completed to
COMPLETED.
> IllegalStateException: ILLEGAL TRANSITION: In LogAppender(s4 -> s1), CLOSING
> -> RUNNING
> ---------------------------------------------------------------------------------------
>
> Key: RATIS-497
> URL: https://issues.apache.org/jira/browse/RATIS-497
> Project: Ratis
> Issue Type: Bug
> Components: server, test
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: r497_20190311.patch, r497_20190312.patch,
> r497_20190314.patch, r497_20190401.patch, r497_20190424.patch
>
>
> This bug happens when a LogAppender is started (startAppender()) and then
> immediately stopped (stopAppender()).
> This bug is not a problem in real application, since an uncaught exception
> with no harm will be thrown, but it will fail unit tests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
