[ 
https://issues.apache.org/jira/browse/RATIS-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870830#comment-16870830
 ] 

Supratim Deka commented on RATIS-595:
-------------------------------------

+1
Thanks [~szetszwo] for the patch.
r595_20190624.patch looks good to me.

It might be useful to keep the assert in SegmentedRaftLog.Task.done() on line 
85, which asserts that the future is not already completed (neither success nor 
exception). 

> appendEntry future should be completed only after the entry is flushed
> ----------------------------------------------------------------------
>
>                 Key: RATIS-595
>                 URL: https://issues.apache.org/jira/browse/RATIS-595
>             Project: Ratis
>          Issue Type: Bug
>          Components: server
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>         Attachments: r595_20190618.patch, r595_20190624.patch
>
>
> This was discovered by [~msingh].  Currently, the appendEntry future complete 
> after the WriteLog task is executed.  However, the entry may not be flushed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to