[
https://issues.apache.org/jira/browse/RATIS-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16883983#comment-16883983
]
Josh Elser commented on RATIS-541:
----------------------------------
{code}
+ // First write batch entries to log.
...
+ // Write single entries to log.
...
{code}
I think it's unnecessary to do both batched and unbatched writes in one
invocation. The tool should just have a "write" and "read" functionality.
When we do a write, either we are specifying batching (number of entries per
batch) or they are written without batching (batch size == 0).
{code}
+ if(tool.numBatches * tool.batchSize > tool.numRecords) {
+ LOG.error( "Number of records to write in batches " +
(tool.numBatches * tool.batchSize)
+ + " are more than total number of records " +
tool.numRecords);
+ return;
+ }
{code}
This feels unnecessary to have to provide -- we should be able to make options
which are mutually exclusive. Let me play around with it to make sure I'm not
expecting something unrealistic.
> Add option to verify correctness of batch and mix of batch and single updates
> data from LogService in VerficiationTool
> ----------------------------------------------------------------------------------------------------------------------
>
> Key: RATIS-541
> URL: https://issues.apache.org/jira/browse/RATIS-541
> Project: Ratis
> Issue Type: Improvement
> Components: LogService
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
> Attachments: RATIS-541.patch, RATIS-541_v2.patch
>
>
> Currently, in the verification tool, we are verifying single updates
> correctness in verification but the same can do for batch and mix of batch
> and single updates.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
