[
https://issues.apache.org/jira/browse/RATIS-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901365#comment-16901365
]
Ankit Singhal commented on RATIS-653:
-------------------------------------
bq. Could you describe how you come the patch? It would be very useful for
everyone.
[~szetszwo], here is the patch on
https://issues.apache.org/jira/browse/RATIS-654 for generating LICENSE and
NOTICE files to include missing license and notice of third-party
dependencies(even the transitive one). These attached files are also created
with this.
bq. do we also need changes in ratis-assembly so that the LICENSE and NOTICE
are picked directly from the root and we do not have to maintain two copies of
the LICENSE and NOTICE.
It seems binary include notice from LICENSE and NOTICE from assembly resources
while src distribution includes from root dir. but we may not need to be that
much verbose for src as it doesn't include any transitive binary. Let me update
the patch accordingly.
Once RATIS-654 is committed, we don't need to do this any more for new
dependencies as LICENSE and NOTICE will automatically updated.
> Fix LICENSE and NOTICE files for release
> ----------------------------------------
>
> Key: RATIS-653
> URL: https://issues.apache.org/jira/browse/RATIS-653
> Project: Ratis
> Issue Type: Bug
> Components: build
> Affects Versions: 0.3.0
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: LICENSE, NOTICE, RATIS-653.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
