[
https://issues.apache.org/jira/browse/RATIS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917105#comment-16917105
]
Ankit Singhal commented on RATIS-556:
-------------------------------------
Thanks [~rajeshbabu] , v2 looks good to me.
can we please do this small change: instead of throwing an exception and
catching outside, can we just WARN here itself and continue processing other
logs(as to avoid immediate retry of the same log and in case if it continues to
fail, then other logs will not ever be tried for close).
{code}
+ try {
+ RaftClientReply reply = client.send(
+ () ->
LogServiceProtoUtil.toChangeStateRequestProto(logName, LogStream.State.CLOSED)
+ .toByteString());
+ LogServiceProtos.ChangeStateReplyProto
message =
+
LogServiceProtos.ChangeStateReplyProto.parseFrom(reply.getMessage().getContent());
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
{code}
> Detect node failures and close the log to prevent additional writes
> -------------------------------------------------------------------
>
> Key: RATIS-556
> URL: https://issues.apache.org/jira/browse/RATIS-556
> Project: Ratis
> Issue Type: Improvement
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
> Attachments: RATIS-556-wip.patch, RATIS-556_v1.patch,
> RATIS-556_v2.patch
>
>
> Currently there is no way to detect the node failures at master log servers
> and add new nodes to the group serving the log. We need to analyze how Ozone
> is working in this case.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
