[
https://issues.apache.org/jira/browse/RATIS-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929101#comment-16929101
]
Shashikant Banerjee commented on RATIS-670:
-------------------------------------------
Thanks [~sdeka] for working on this. The patch overall looks good to me. Few
comments inline:
1. Can we change the naming here? it looks confusing.
{code:java}
public static final String RATIS_APPLIED_INDEX_GAUGE =
"ratis_applied_index";
public static final String STATEMACHINE_APPLIED_INDEX_GAUGE =
"statemachine_applied_index";
{code}
2. Can we add a new test altogether just verifying the metric value instead of
modifying existing "testRequestTiemout" test?
> Add a metric to track StateMachine Log apply index
> --------------------------------------------------
>
> Key: RATIS-670
> URL: https://issues.apache.org/jira/browse/RATIS-670
> Project: Ratis
> Issue Type: Sub-task
> Components: server
> Reporter: Supratim Deka
> Assignee: Supratim Deka
> Priority: Major
> Attachments: RATIS-670.000.patch, RATIS-670.001.patch,
> RATIS-670.002.patch, RATIS-670.003.patch, RATIS-670.004.patch,
> RATIS-670.005.patch
>
>
> Plotting the Log apply index (log index applied on the StateMachine) against
> the RaftLog commit index, is useful in monitoring the performance of the
> statemachine.
> This jira adds a metric/gauge which tracks the current value of log apply
> index.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
