[
https://issues.apache.org/jira/browse/RATIS-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931461#comment-16931461
]
Lokesh Jain commented on RATIS-647:
-----------------------------------
[~avijayan] Thanks for working on this! The changes look good to me. Please
find my comments below.
# RatisMetricNames:48 - RAFT_LOG_DATA_QUEUE_SIZE would give the number of raft
log related operations in the queue. It can include WriteLog,
FinalizeLogSegment etc. Similarly line 66 and 69 need to be updated.
# SegmentedRaftLogWorker - We might also want to add a timer for the execution
time of tasks in the raft log queue. The execution time can be separate for log
and state machine related operations.
# We can merge RatisMetricNames and RatisMetrics and add a hierarchy like
RaftServerConfigKeys and RaftClientConfigKeys. We can create a separate Jira
for that if it makes sense?
# TestLogSegment:238 - Change needs to be reverted.
> Create metrics associated with RaftLog for RaftServer
> -----------------------------------------------------
>
> Key: RATIS-647
> URL: https://issues.apache.org/jira/browse/RATIS-647
> Project: Ratis
> Issue Type: Sub-task
> Components: server
> Affects Versions: 0.4.0
> Reporter: Shashikant Banerjee
> Assignee: Aravindan Vijayan
> Priority: Major
> Fix For: 0.4.0
>
> Attachments: RATIS-647-000.patch, RATIS-647-001.patch,
> RATIS-647-002.patch
>
>
> We need the following metrics related to RaftLog and RaftLogWorker:
> |raftLogSyncLatency|Time taken to sync raft log|
> |numRaftLogSyncOps|Number of Raft log sync calls with respect to time(equals
> no of FlushStateMacine Calls)|
> |raftLogSynBatchSize|No of raft log entries synced with each flush call|
> |raftLogReadLatency|Time required to read a raft log entry from actual raft
> log file and create a raft log entry (Raft log read latency)|
> |raftLogAppendLatency|Total time taken to append a raft log entry (this also
> includes writeStateMachineData which will vary depending upon the size of the
> data to be written as well as external factors)|
> |raftLogEnqueuedTime|Time of RaftLogEntry in the Raft Log Worker Queue|
> |raftLogQueueingDelay|Time required to enqueue a raft Log entry in raft log
> worker queue|
> |raftLogSegmentLoadLatency|Time required to load and process raft log
> segments during restart|
> |raftLogWorkerQueueSize|Raft log worker queue size which at any time gives
> the no of pending log entries to be committed to the raft log.|
> |raftLogCacheMissCount|Number of RaftLogCacheMisses |
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
