[
https://issues.apache.org/jira/browse/RATIS-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16935814#comment-16935814
]
Lokesh Jain commented on RATIS-603:
-----------------------------------
[~msingh] Thanks for working on this! The changes look good to me. Please find
my comments below.
# RaftLog:30, 32 - Unused import
# EntryWithData - I think it might be easier to send a string supplier while
constructing the EntryWithData object. Then we don't require a SMEntryWithData
class.
# StateMachine#toSMLogEntryString - We can add a javadoc.
> Add a logStringSupplier for RaftServerImpl to optionally print SmLogEntry on
> errors
> -----------------------------------------------------------------------------------
>
> Key: RATIS-603
> URL: https://issues.apache.org/jira/browse/RATIS-603
> Project: Ratis
> Issue Type: New Feature
> Components: server
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Labels: ozone
> Attachments: RATIS-603.001.patch, RATIS-603.002.patch,
> RATIS-603.003.patch, RATIS-603.004.patch, RATIS-603.005.patch
>
>
> This jira proposes to add a SmLogEntryProto to toString converter so that
> logEntry information can be printed on errors/exceptions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
