[ 
https://issues.apache.org/jira/browse/RATIS-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16948729#comment-16948729
 ] 

Aravindan Vijayan commented on RATIS-676:
-----------------------------------------

[~shashikant] Thanks for the review. Yes, I think we can just change the rename 
the class RaftLeaderMetrics to RaftServerMetrics. The only metrics in this 
class are *follower_%s_lastHeartbeatElapsedTime* and *%s_peerCommitIndex*. If 
the peer is a leader, it will have both the metrics and if it is a follower, it 
will have only the latter metric. We dont need to tag these metrics as 
LeaderMetrics. Does that make sense? 

> Add a metric in RaftServer to track the Log Commit Index
> --------------------------------------------------------
>
>                 Key: RATIS-676
>                 URL: https://issues.apache.org/jira/browse/RATIS-676
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: server
>            Reporter: Supratim Deka
>            Assignee: Aravindan Vijayan
>            Priority: Major
>         Attachments: RATIS-676-000.patch, RATIS-676-001.patch
>
>
> RATIS-650 tracks the commit indexes of each peer in a RaftGroup - tracking is 
> done as metrics on the RAFT group leader.
> This jira however tracks the RaftLog commit index as a metric of the local 
> RaftServer. This metric will be reported by all nodes running a raft server 
> irrespective of their role (Leader or Follower).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to