[ 
https://issues.apache.org/jira/browse/RATIS-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950116#comment-16950116
 ] 

Henrik Hegardt commented on RATIS-702:
--------------------------------------

No problems, and looking at it I think it is a better solution for now, and if 
one decides to remove the dependency on DW3 it's one step towards a possible 
removal.

> Making ratis metrics totally vendor independent is a bigger task as we have 
> dropwizard interfaces in our interfaces. Supporting both 3 and 4 dropwizard 
> seems to be easier. As far as I see after this patch only the JVMMetrics 
> depends on dropwizard metrics 3 and all the others interfaces are compatible.

Yes, it sure is a bigger job :). But I think your patch is good enough. I've 
tried to run with DWM4 and it seems to run ok, though it's not a thurough test.

I do think that the ganglia dependency could be removed. DWM4 doesn't seem to 
have something equal to it.

 

> Make metrics reporting implementation pluggable
> -----------------------------------------------
>
>                 Key: RATIS-702
>                 URL: https://issues.apache.org/jira/browse/RATIS-702
>             Project: Ratis
>          Issue Type: Wish
>          Components: metrics
>            Reporter: Henrik Hegardt
>            Assignee: Marton Elek
>            Priority: Major
>         Attachments: RATIS-702.001.patch, RATIS-702.002.patch
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> It would be really nice if the metrics functionality also was pluggable so 
> one could choose how to report metrics.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to