[ 
https://issues.apache.org/jira/browse/RATIS-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955104#comment-16955104
 ] 

Tsz-wo Sze commented on RATIS-648:
----------------------------------

TestMetaServer.testDeleteLog() is failing with NullPointerException.  It seems 
related to this.
{code}
2019-10-19 15:59:17,894 INFO  segmented.SegmentedRaftLogWorker 
(SegmentedRaftLogWorker.java:execute(576)) - 
localhost_10000@group-000000000002-SegmentedRaftLogWorker: created new log 
segment 
/Users/szetswo/ratis/incubator-ratis/ratis-logservice/target/test/data/dbb029a4/workers/0/00000000-0000-0000-0000-000000000002/current/log_inprogress_0
SEVERE: Exception while executing runnable 
org.apache.ratis.thirdparty.io.grpc.internal.ClientCallImpl$ClientStreamListenerImpl$1MessagesAvailable@494b5f3e
java.lang.NullPointerException
        at 
org.apache.ratis.grpc.server.GrpcLogAppender$AppendLogResponseHandler.onError(GrpcLogAppender.java:303)
        at 
org.apache.ratis.thirdparty.io.grpc.stub.ClientCalls$StreamObserverToCallListenerAdapter.onClose(ClientCalls.java:434)
        ...
{code}

I did a bad job of committing RATIS-702 without first making sure that all 
tests passed so that I am checking the test failures.
We need to do better.  💪

> Add metrics related to GrpcLogAppendRequests 
> ---------------------------------------------
>
>                 Key: RATIS-648
>                 URL: https://issues.apache.org/jira/browse/RATIS-648
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: server
>    Affects Versions: 0.4.0
>            Reporter: Shashikant Banerjee
>            Assignee: Siddharth Wagle
>            Priority: Major
>             Fix For: 0.5.0
>
>         Attachments: RATIS-648.00.patch, RATIS-648.01.patch, 
> RATIS-648.02.patch, RATIS-648.03.patch, RATIS-648.04.patch, RATIS-648.05.patch
>
>
> Following metrics would be useful related to GrpcLogAppends for performance 
> and health monitoring and tuning:
> |GrpcLogAppenderLatency|Time taken to append a log entry to each follower and 
> get acknowledgement|
> |logAppendRetryCount|Total no of retried logAppends requests|
> |logAppendRequestCount|Total no of logAppendRequest|
> |appendEntryProcessingLatency|Time required to process an append entry 
> request on each follower|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to