[ 
https://issues.apache.org/jira/browse/RATIS-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964127#comment-16964127
 ] 

Tsz-wo Sze commented on RATIS-508:
----------------------------------

Thanks for the detail explanation.

> Since log4j is declared in test scope in DM, this would mean that like the 
> ratis-hadoop module now will have it's transitive dependency on log4j be in 
> scope test as well, meaning that in runtime, that Maven will have omitted 
> log4j, ...

The right thing to do seems to drop the test scope in DM.  Then,
- ratis-hadoop will get compile scope from Hadoop-common, and
- other modules like ratis-common, ratis-grpc, etc. will remain having test 
scope getting from slf4j-log4j12.

Just have tried it locally, it seems working well.  Could you see if it works 
for you?


> Switch from log4j to slf4j
> --------------------------
>
>                 Key: RATIS-508
>                 URL: https://issues.apache.org/jira/browse/RATIS-508
>             Project: Ratis
>          Issue Type: Improvement
>          Components: common
>    Affects Versions: 0.4.0
>            Reporter: Hai Zhou
>            Assignee: Henrik Hegardt
>            Priority: Major
>             Fix For: 0.5.0
>
>         Attachments: RATIS-508.001.patch, RATIS-508.002.patch
>
>
> Improve the request to raise the abstraction level of our logging framework 
> so that logging is done through slf4j instead of directly through log4j. 
> This will allow users to swap-out the underlying logging framework, giving a 
> choice of log4j, logback-classic, and log4j2.
> eg.
> In my project, I use logback, which conflicts with log4j.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to