[
https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964465#comment-16964465
]
Hanisha Koneru edited comment on RATIS-729 at 11/1/19 12:10 AM:
----------------------------------------------------------------
[~ljain], for the other Raft Exceptions, do we want to have a separate field
for each in RaftClientReplyProto or just one field encompassing all the other
RaftExceptions?
I posted a patch with the later approach as none of the other RaftExceptions
had any other parameter specifically associated to them.
was (Author: hanishakoneru):
[~ljain], for the other Raft Exceptions, do we want to have a separate field
for each in RaftClientReplyProto or just one field encompassing all the other
RaftExceptions?
I posted a patch with the 2nd approach as none of the other RaftExceptions had
any other parameter specifically associated to them.
> ClientProtoUtils#toRaftClientReplyProto should consider all RaftException
> types
> -------------------------------------------------------------------------------
>
> Key: RATIS-729
> URL: https://issues.apache.org/jira/browse/RATIS-729
> Project: Ratis
> Issue Type: Bug
> Reporter: Lokesh Jain
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: RATIS-729.001.patch
>
>
> In one of the runs it is seen that client receives RaftClientReply with
> exception as null and success flag as false. This happens because currently
> ClientProtoUtils#toRaftClientReplyProto only considers a few RaftException
> types while creating a RaftClientReplyProto. We should also add handling for
> other exception types.Similar changes will be required in
> ClientProtoUtils#toRaftClientReply.
> We will also need to add handling for these exceptions in the client code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
