[
https://issues.apache.org/jira/browse/RATIS-580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16967432#comment-16967432
]
Lokesh Jain commented on RATIS-580:
-----------------------------------
[~szetszwo] Thanks for working on this! The patch looks good to me. I have some
minor comments.
# Can we rename RetryPolicy.RETRY_WITHOUT_SLEEP and RetryPolicy.NO_RETRY and
probably add an ACTION suffix? We have similar names in RetryPolicies class.
# Can we also rename RetryPolicy.attemptFailed to sth like handleEvent or
handleAttemptFailure?
# RaftAsyncTests has some unused imports.
# There are few checkstyle issues.
> Refactor retryPolicy for RaftClient to customize wait time based on exception
> ------------------------------------------------------------------------------
>
> Key: RATIS-580
> URL: https://issues.apache.org/jira/browse/RATIS-580
> Project: Ratis
> Issue Type: Improvement
> Components: client
> Affects Versions: 0.4.0
> Reporter: Siddharth Wagle
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: ozone
> Attachments: r580_20191031.patch, r580_20191101.patch
>
>
> Follow-up from RATIS-574. Similar to request based customization, the
> RetryPolicy interface should allow for customized sleepTime based on the
> exception.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
