[
https://issues.apache.org/jira/browse/RATIS-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968255#comment-16968255
]
Lokesh Jain commented on RATIS-652:
-----------------------------------
[~avijayan] Thanks for working on this! The changes look good to me. Please
find my comments below.
# PurgeLog class does not require RaftLogMetrics field. It can use the outer
class field itself.
# Can we rename TAKE_SNAPSHOT_TIMER to STATEMACHINE_TAKE_SNAPSHOT_TIMER?
# Can we also add unit tests around the metrics?
> Add metrics related to snapshot and log purge
> ---------------------------------------------
>
> Key: RATIS-652
> URL: https://issues.apache.org/jira/browse/RATIS-652
> Project: Ratis
> Issue Type: Sub-task
> Components: server
> Reporter: Shashikant Banerjee
> Assignee: Aravindan Vijayan
> Priority: Major
> Fix For: 0.5.0
>
> Attachments: RATIS-652-000.patch, RATIS-652-001.patch
>
>
> Following metrics would be good to determine overall snapshot and log purge
> behaviour of a ratis pipeline:
>
> |takeSnapshotLatency|Time taken to take a ratis snapshot.|
> |numSnapshots|Number of snapshots taken |
> |purgeLogRecordLatency|Time taken to purge logRecords.|
> |numPurgeLogCalls|Number of Purge log calls|
> |numInstallSnapshotOps|Number of install snapshot calls|
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
