[
https://issues.apache.org/jira/browse/RATIS-740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16976900#comment-16976900
]
Tsz-wo Sze commented on RATIS-740:
----------------------------------
Thanks for the update, [~dineshchitlangia]. Some more comments:
- In MD5Hash.setDigest, just use the digest field directly and remove the local
variable.
- Change AtomicUtils to an interface.
- In AutoCloseableReadWriteLock.logLocking, remove the objectName parameter.
Just use the name field inside. It wil also fix the long line problem.
- Is a checkstyle warning for convert multiple imports to "import java.io.*;"?
It actually is a bad style considered by many such as
https://stackoverflow.com/questions/187453/import-package-vs-import-package-specifictype
> Fix checkstyle violations in ratis-common
> -----------------------------------------
>
> Key: RATIS-740
> URL: https://issues.apache.org/jira/browse/RATIS-740
> Project: Ratis
> Issue Type: Sub-task
> Components: common
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Attachments: RATIS-740.001.patch, RATIS-740.002.patch,
> RATIS-740.003.patch
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Fix checkstyle violations in ratis-common module
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
