[
https://issues.apache.org/jira/browse/RATIS-729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978488#comment-16978488
]
Tsz-wo Sze commented on RATIS-729:
----------------------------------
> ... But this can lead to server failure. ...
Server failure in this case is desirable if it is a bug. If we find that it is
not a bug, we can remove the precondition then.
{code}
+ Preconditions.assertTrue(r.getException().equals(reply.getException()));
{code}
BTW, the code above won't work since getException() may return null and stack
trace will be different. We probably should first check null and then compare
the exception classes.
> ClientProtoUtils#toRaftClientReplyProto should consider all RaftException
> types
> -------------------------------------------------------------------------------
>
> Key: RATIS-729
> URL: https://issues.apache.org/jira/browse/RATIS-729
> Project: Ratis
> Issue Type: Bug
> Components: client
> Reporter: Lokesh Jain
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: RATIS-729.001.patch
>
>
> In one of the runs it is seen that client receives RaftClientReply with
> exception as null and success flag as false. This happens because currently
> ClientProtoUtils#toRaftClientReplyProto only considers a few RaftException
> types while creating a RaftClientReplyProto. We should also add handling for
> other exception types.Similar changes will be required in
> ClientProtoUtils#toRaftClientReply.
> We will also need to add handling for these exceptions in the client code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
