[
https://issues.apache.org/jira/browse/RATIS-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16980517#comment-16980517
]
Tsz-wo Sze commented on RATIS-756:
----------------------------------
- In RaftGroup, change EMPTY_GROUP to final but don't rename it.
- In RaftId, rename the uuid parameter to id.
- There are a few incorrect indentation changes in RaftProperties.loadResource.
- Don't change PlatformUtils, it should be removed with NativeIO.
- In ReflectionUtils, change EMPTY_ARRAY and CLASS_LOADER to final.
{code}
private static final ClassLoader CLASS_LOADER = Optional.ofNullable(
Thread.currentThread().getContextClassLoader()).orElseGet(ReflectionUtils.class::getClassLoader);
{code}
> Fix identified names in ratis-common
> ------------------------------------
>
> Key: RATIS-756
> URL: https://issues.apache.org/jira/browse/RATIS-756
> Project: Ratis
> Issue Type: Sub-task
> Components: common
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Attachments: RATIS-756.001.patch
>
>
> Based on review comment from [~szetszwo], this jira aims to renames the
> identifiers appropriately.
> https://issues.apache.org/jira/browse/RATIS-740?focusedCommentId=16968565&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16968565
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
