[
https://issues.apache.org/jira/browse/RATIS-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988331#comment-16988331
]
Hadoop QA commented on RATIS-765:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
5s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
5s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 18m 52s{color}
| {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
18s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 23s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | ratis.logservice.server.TestMetaServer |
| | ratis.grpc.TestRaftAsyncWithGrpc |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.5 Server=19.03.5 Image:yetus/ratis:date2019-12-05 |
| JIRA Issue | RATIS-765 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12987513/RATIS-765.001.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
checkstyle compile cc |
| uname | Linux 4c42ab368edb 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1
05:24:09 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-RATIS-Build/yetus-personality.sh
|
| git revision | master / 22ceab2 |
| maven | version: Apache Maven 3.6.2
(40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T15:06:16Z) |
| Default Java | 1.8.0_222 |
| unit |
https://builds.apache.org/job/PreCommit-RATIS-Build/1180/artifact/out/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-RATIS-Build/1180/testReport/ |
| asflicense |
https://builds.apache.org/job/PreCommit-RATIS-Build/1180/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 2931 (vs. ulimit of 5000) |
| modules | C: ratis-proto ratis-client U: . |
| Console output |
https://builds.apache.org/job/PreCommit-RATIS-Build/1180/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> ClientProtoUtils#toRaftClientReplyProto should handle AlreadyClosedException
> ----------------------------------------------------------------------------
>
> Key: RATIS-765
> URL: https://issues.apache.org/jira/browse/RATIS-765
> Project: Ratis
> Issue Type: Bug
> Reporter: Lokesh Jain
> Assignee: Hanisha Koneru
> Priority: Major
> Attachments: RATIS-765.001.patch
>
>
> TestWatchRequestWithGrpc failed with the below exception. This is a result of
> assertion added in RATIS-729. In ClientProtoUtils#toRaftClientReplyProto we
> currently do not propagate AlreadyClosedException in the RaftClientReplyProto.
> {code:java}
> java.lang.AssertionError: Unexpected exit.
> at org.apache.ratis.util.ExitUtils.assertNotTerminated(ExitUtils.java:109)
> at org.apache.ratis.BaseTest.assertNoFailures(BaseTest.java:75)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
> at
> org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.ratis.util.ExitUtils$ExitException:
> Thread[grpc-default-executor-5,5,FailOnTimeoutGroup] has thrown an uncaught
> exception
> at org.apache.ratis.util.ExitUtils.terminate(ExitUtils.java:141)
> at org.apache.ratis.util.ExitUtils$States.lambda$new$0(ExitUtils.java:54)
> at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1057)
> at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1052)
> at java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1052)
> at java.lang.Thread.dispatchUncaughtException(Thread.java:1959)
> Caused by: java.lang.AssertionError: Corruption while serializing reply=
> RaftClientReply:client-8FD5A15E01C2->s2@group-435584180CC1, cid=6, FAILED
> org.apache.ratis.protocol.AlreadyClosedException:
> SlidingWindow$Server:2-OrderedRequestStreamObserver2 is closing: seq = 3 >
> nextToProcess = -1 will NEVER be processed; request = 3:null, logIndex=0,
> commits[] but serialized=rpcReply {
> requestorId: "\357\216\347\031)\304Ii\200\273\217\325\241^\001\302"
> replyId: "s2"
> raftGroupId {
> id: "\256\245\022M\323PHF\207\220CU\204\030\f\301"
> }
> callId: 6
> }
> and deserialized=RaftClientReply:client-8FD5A15E01C2->s2@group-435584180CC1,
> cid=6, FAILED null, logIndex=0, commits[]
> at
> org.apache.ratis.client.impl.ClientProtoUtils.toRaftClientReplyProto(ClientProtoUtils.java:205)
> at
> org.apache.ratis.grpc.client.GrpcClientProtocolService$OrderedRequestStreamObserver.sendReply(GrpcClientProtocolService.java:355)
> at
> org.apache.ratis.util.SlidingWindow$RequestMap.endOfRequests(SlidingWindow.java:158)
> at
> org.apache.ratis.util.SlidingWindow$Server.endOfRequests(SlidingWindow.java:469)
> at
> org.apache.ratis.grpc.client.GrpcClientProtocolService$OrderedRequestStreamObserver.onCompleted(GrpcClientProtocolService.java:368)
> at
> org.apache.ratis.thirdparty.io.grpc.stub.ServerCalls$StreamingServerCallHandler$StreamingServerCallListener.onHalfClose(ServerCalls.java:262)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:814)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
> at
> org.apache.ratis.thirdparty.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: org.apache.ratis.protocol.AlreadyClosedException:
> SlidingWindow$Server:2-OrderedRequestStreamObserver2 is closing: seq = 3 >
> nextToProcess = -1 will NEVER be processed; request = 3:null
> at
> org.apache.ratis.util.SlidingWindow$RequestMap.endOfRequests(SlidingWindow.java:155)
> ... 10 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
