Attila Doroszlai created RATIS-828:
--------------------------------------
Summary: Logs cluttered by AlreadyExistsException
Key: RATIS-828
URL: https://issues.apache.org/jira/browse/RATIS-828
Project: Ratis
Issue Type: Wish
Components: server
Reporter: Attila Doroszlai
Follow-up for HDDS-3148:
Ozone startup logs are cluttered by printing stack trace of
AlreadyExistsException related to group addition. Example:
{code}
2020-03-09 13:53:01,563 [grpc-default-executor-0] WARN impl.RaftServerProxy
(RaftServerProxy.java:lambda$groupAddAsync$11(390)) -
7a07f161-9144-44b2-8baa-73f0e9299675: Failed groupAdd*
GroupManagementRequest:client-27FB1A91809E->7a07f161-9144-44b2-8baa-73f0e9299675@group-E151028E3AC0,
cid=2, seq=0, RW, null,
Add:group-E151028E3AC0:[18f4e257-bf09-482e-b1bb-a2408a093ff7:172.17.0.2:43845,
7a07f161-9144-44b2-8baa-73f0e9299675:172.17.0.2:41551,
8a66c80e-ab55-4975-92a9-8aaf06ab418a:172.17.0.2:36921]
java.util.concurrent.CompletionException:
org.apache.ratis.protocol.AlreadyExistsException:
7a07f161-9144-44b2-8baa-73f0e9299675: Failed to add
group-E151028E3AC0:[18f4e257-bf09-482e-b1bb-a2408a093ff7:172.17.0.2:43845,
7a07f161-9144-44b2-8baa-73f0e9299675:172.17.0.2:41551,
8a66c80e-ab55-4975-92a9-8aaf06ab418a:172.17.0.2:36921] since the group already
exists in the map.
at
java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292)
at
java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308)
at
java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:607)
at
java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591)
at
java.util.concurrent.CompletableFuture.uniApplyStage(CompletableFuture.java:631)
at
java.util.concurrent.CompletableFuture.thenApplyAsync(CompletableFuture.java:2006)
at
org.apache.ratis.server.impl.RaftServerProxy.groupAddAsync(RaftServerProxy.java:379)
at
org.apache.ratis.server.impl.RaftServerProxy.groupManagementAsync(RaftServerProxy.java:363)
at
org.apache.ratis.grpc.server.GrpcAdminProtocolService.lambda$groupManagement$0(GrpcAdminProtocolService.java:42)
at org.apache.ratis.grpc.GrpcUtil.asyncCall(GrpcUtil.java:160)
at
org.apache.ratis.grpc.server.GrpcAdminProtocolService.groupManagement(GrpcAdminProtocolService.java:42)
at
org.apache.ratis.proto.grpc.AdminProtocolServiceGrpc$MethodHandlers.invoke(AdminProtocolServiceGrpc.java:358)
at
org.apache.ratis.thirdparty.io.grpc.stub.ServerCalls$UnaryServerCallHandler$UnaryServerCallListener.onHalfClose(ServerCalls.java:172)
at
org.apache.ratis.thirdparty.io.grpc.internal.ServerCallImpl$ServerStreamListenerImpl.halfClosed(ServerCallImpl.java:331)
at
org.apache.ratis.thirdparty.io.grpc.internal.ServerImpl$JumpToApplicationThreadServerStreamListener$1HalfClosed.runInContext(ServerImpl.java:814)
at
org.apache.ratis.thirdparty.io.grpc.internal.ContextRunnable.run(ContextRunnable.java:37)
at
org.apache.ratis.thirdparty.io.grpc.internal.SerializingExecutor.run(SerializingExecutor.java:123)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.ratis.protocol.AlreadyExistsException:
7a07f161-9144-44b2-8baa-73f0e9299675: Failed to add
group-E151028E3AC0:[18f4e257-bf09-482e-b1bb-a2408a093ff7:172.17.0.2:43845,
7a07f161-9144-44b2-8baa-73f0e9299675:172.17.0.2:41551,
8a66c80e-ab55-4975-92a9-8aaf06ab418a:172.17.0.2:36921] since the group already
exists in the map.
at
org.apache.ratis.server.impl.RaftServerProxy$ImplMap.addNew(RaftServerProxy.java:83)
at
org.apache.ratis.server.impl.RaftServerProxy.groupAddAsync(RaftServerProxy.java:378)
... 13 more
{code}
Since these are "normal", I think stack trace should be suppressed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
