[ 
https://issues.apache.org/jira/browse/RATIS-832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17076081#comment-17076081
 ] 

runzhiwang edited comment on RATIS-832 at 4/6/20, 7:11 AM:
-----------------------------------------------------------

[~shashikant] Could you help review this patch ? Thank you very much.  I did 
not implement metric for cache size in bytes. Because 
com.google.common.cache.Cache does not have the API to get the cache size in 
bytes. If I implement it myself, it will not be accurate, because the cache 
size depends on the data structure used by com.google.common.cache.Cache.


was (Author: runzhiwang):
[~shashikant] Could you help review this patch ? Thank you very much.  I did 
not implement metric for cache size in bytes. Because 
com.google.common.cache.Cache does not have the API to get the cache size. If I 
implement it myself, it will not be accurate, because the cache size depends on 
the data structure used by com.google.common.cache.Cache.

> Add Metrics for retry cache count as well as size in bytes
> ----------------------------------------------------------
>
>                 Key: RATIS-832
>                 URL: https://issues.apache.org/jira/browse/RATIS-832
>             Project: Ratis
>          Issue Type: Sub-task
>          Components: server
>    Affects Versions: 0.6.0
>            Reporter: Shashikant Banerjee
>            Priority: Major
>         Attachments: RATIS-832.001.patch
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to