[ 
https://issues.apache.org/jira/browse/RATIS-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084477#comment-17084477
 ] 

Ankit Singhal commented on RATIS-622:
-------------------------------------

Committed after rebasing
{code}
commit a1785b7d8b90c420e82fa7db21195c1bed051a6f (HEAD -> master, origin/master)
Author: Josh Elser <[email protected]>
Date:   Wed Apr 15 18:47:58 2020 -0700

    RATIS-622 createLog will block indefinitely if group creation fails

    Signed-off-by: Ankit Singhal <[email protected]>
{code}

As per the latest failures in the Jenkins related to logservice, added a check 
also to ensure that there are at least 3 workers prior running each test 

> createLog will block indefinitely if group creation fails
> ---------------------------------------------------------
>
>                 Key: RATIS-622
>                 URL: https://issues.apache.org/jira/browse/RATIS-622
>             Project: Ratis
>          Issue Type: Bug
>          Components: LogService
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 0.6.0
>
>         Attachments: RATIS-622.001.patch
>
>
> I've seen this bug a few times, but finally got to the bottom of it. The 
> VerificationTool will get to the end, but not exit. The reason is that at 
> least one log has still not yet been created.
> * The client will be blocked asking the metadataquorum to create a log
> * The metadata leader will have tons of threads blocked on the writeLock
> What I just found today was an exception, logged to stderr (not stdout), that 
> was thrown when the group create failed.
> However, we don't catch and re-throw this exception on group create failure, 
> but proceed then to try to send a message to the group which failed to be 
> created.
> We must catch this failure, try to clean up, and propagate the original 
> createLog exception back to the client.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to