[
https://issues.apache.org/jira/browse/RATIS-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17090351#comment-17090351
]
Tsz-wo Sze commented on RATIS-841:
----------------------------------
Why skilling client.handleLeaderException? In RaftServerImpl.checkLeaderState,
we do put LeaderNotReadyException in a reply.
{code}
//RaftServerImpl.checkLeaderState
final LeaderNotReadyException lnre = new
LeaderNotReadyException(getMemberId());
final RaftClientReply reply = new RaftClientReply(request, lnre,
getCommitInfos());
return RetryCache.failWithReply(reply, entry);
{code}
> Remove unnecessary exception checks in OrderedAsync#sendRequest
> ---------------------------------------------------------------
>
> Key: RATIS-841
> URL: https://issues.apache.org/jira/browse/RATIS-841
> Project: Ratis
> Issue Type: Bug
> Components: client
> Reporter: Lokesh Jain
> Assignee: Lokesh Jain
> Priority: Major
> Attachments: RATIS-841.001.patch, RATIS-841.002.patch
>
>
> OrderedAsync#sendRequest does not require exception checks for
> NotLeaderException as RafClientReply is already checked for these exceptions
> in GrpcClientProtocolClient$AsyncStreamObservers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
