[ 
https://issues.apache.org/jira/browse/ROCKETMQ-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16209410#comment-16209410
 ] 

Anh Le commented on ROCKETMQ-4:
-------------------------------

[~eric.liu] I think Roman's approach is suitable. Do you want me to refactor 
the code?

> Extract all RocketMQ constants from MixAll to RocketMQProperties class
> ----------------------------------------------------------------------
>
>                 Key: ROCKETMQ-4
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-4
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>             Fix For: 4.3.0
>
>
> {{MixAll}} contains helper methods and constants that are mostly not used by 
> those methods, but used through all the code base.
> I propose to gather all constants into {{RocketMQProperties}} class in the 
> same directory, and move helper methods to {{UtilAll}}.
> Any objections?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to