[ 
https://issues.apache.org/jira/browse/ROCKETMQ-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290407#comment-16290407
 ] 

ASF GitHub Bot commented on ROCKETMQ-239:
-----------------------------------------

lindzh commented on a change in pull request #129: [ROCKETMQ-239]fix query 
message by time and fix get queue offset by time
URL: https://github.com/apache/rocketmq/pull/129#discussion_r156864077
 
 

 ##########
 File path: store/src/main/java/org/apache/rocketmq/store/MessageStore.java
 ##########
 @@ -118,7 +118,7 @@ GetMessageResult getMessage(final String group, final 
String topic, final int qu
      * @param timestamp Timestamp to look up.
 
 Review comment:
   Yes,and the JavaDoc if param isGetTimeLast has been added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Query message by time and get queue offset by time return is always less than 
> want. 
> ------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-239
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-239
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-store
>    Affects Versions: 4.1.0-incubating
>            Reporter: lindzh
>            Assignee: yukon
>             Fix For: 4.3.0
>
>
> When using queryMessageByTime or searchOffsetByTime or resetOffsetByTime , 
> DefaultMessageStore return offset is not so accurate as we want.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to