[ 
https://issues.apache.org/jira/browse/ROCKETMQ-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16361790#comment-16361790
 ] 

ASF GitHub Bot commented on ROCKETMQ-346:
-----------------------------------------

coveralls commented on issue #226: [ROCKETMQ-346] One message could only has 
one tag,“tags” is confusing
URL: https://github.com/apache/rocketmq/pull/226#issuecomment-365143777
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/15496912/badge)](https://coveralls.io/builds/15496912)
   
   Coverage increased (+0.03%) to 39.907% when pulling 
**76bec8a4f772cf41a296ed8dc4549fb6b30f6899 on mark800:ROCKETMQ-346** into 
**2d43e75eb3789b02dd4f65865ac34ad10652f6ce on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> the parameter’s name in Message Class’s construction should not be plural
> -------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-346
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-346
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-commons
>            Reporter: Mark Yang
>            Assignee: Jixiang Jin
>            Priority: Major
>
> public Message(String topic, String tags, byte[] body) {
>         this(topic, tags, "", 0, body, true);
> }
> “tags” is plural,but one message could only has one tag,“tags” is confusing 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to