[
https://issues.apache.org/jira/browse/ROCKETMQ-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387389#comment-16387389
]
ASF GitHub Bot commented on ROCKETMQ-359:
-----------------------------------------
vongosling commented on a change in pull request #221: [ROCKETMQ-359] Replace
slf4j api used in RocketMQ with InternalLogger
URL: https://github.com/apache/rocketmq/pull/221#discussion_r172425109
##########
File path:
remoting/src/main/java/org/apache/rocketmq/remoting/common/ServiceThread.java
##########
@@ -16,14 +16,15 @@
*/
package org.apache.rocketmq.remoting.common;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+
+import org.apache.rocketmq.logging.InternalLogger;
Review comment:
Manual replace?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace slf4j api used in RocketMQ with InternalLogger
> ------------------------------------------------------
>
> Key: ROCKETMQ-359
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-359
> Project: Apache RocketMQ
> Issue Type: Improvement
> Affects Versions: 4.2.0
> Reporter: lindzh
> Assignee: vongosling
> Priority: Major
> Fix For: 4.3.0
>
>
> Since Logger is used any where and there is many loggers for us to choose,In
> many cases we have to isolate our logger with other loggers. In my opinion
> use an isolated logger is necessary.
> ------------------------- logging isolation has been fix with logging
> component
> And it is necessary to replace slf4j api used in RocketMQ with InternalLogger
> now!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
