[
https://issues.apache.org/jira/browse/ROCKETMQ-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387415#comment-16387415
]
ASF GitHub Bot commented on ROCKETMQ-319:
-----------------------------------------
vongosling commented on a change in pull request #205: [ROCKETMQ-319] Improve
broker register performance and reduce memory usage
URL: https://github.com/apache/rocketmq/pull/205#discussion_r172422781
##########
File path:
common/src/main/java/org/apache/rocketmq/common/protocol/header/namesrv/QueryDataVersionRequestHeader.java
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.common.protocol.header.namesrv;
+
+import org.apache.rocketmq.remoting.CommandCustomHeader;
+import org.apache.rocketmq.remoting.annotation.CFNotNull;
+import org.apache.rocketmq.remoting.exception.RemotingCommandException;
+
+public class QueryDataVersionRequestHeader implements CommandCustomHeader {
+ @CFNotNull
Review comment:
Please remove this annotation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> improve broker register performance and reduce memory usage
> -----------------------------------------------------------
>
> Key: ROCKETMQ-319
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-319
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker, rocketmq-namesrv
> Affects Versions: 4.0.0-incubating, 4.1.0-incubating
> Reporter: yubaofu
> Assignee: yukon
> Priority: Major
>
> when MQ broker cluster manage topic size very large, eg 10,000+，when MQ
> Broker register meta info to name server，cause mq broker gc problem,so we
> fixed it .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
