[
https://issues.apache.org/jira/browse/ROCKETMQ-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772042#comment-15772042
]
ASF GitHub Bot commented on ROCKETMQ-10:
----------------------------------------
GitHub user nottyjay reopened a pull request:
https://github.com/apache/incubator-rocketmq/pull/4
[ROCKETMQ-10] Null check is not needed -- can't be null when reaches this
point.
Validators.checkGroup(String group) will ensure group is not null
JIRA Issue: https://issues.apache.org/jira/browse/ROCKETMQ-10
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nottyjay/incubator-rocketmq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 32e6333a73e72a8282aa0d26bac38136a0c6d747
Author: Nottyjay <[email protected]>
Date: 2016-12-22T10:11:46Z
Null check is not needed -- can't be null when reaches this point.
----
> Delete unuseful check null
> --------------------------
>
> Key: ROCKETMQ-10
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-10
> Project: Apache RocketMQ
> Issue Type: Wish
> Reporter: Nottyjay
>
> In DefaultMQProducerImpl.java line 599:
> Validators.checkGroup(String group) will ensure
> this.defaultMQPullConsumer.getConsumerGroup() is not null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
