[
https://issues.apache.org/jira/browse/ROCKETMQ-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15779896#comment-15779896
]
ASF GitHub Bot commented on ROCKETMQ-14:
----------------------------------------
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/2
Source code seems ok, please @zhouxinyu @lollipopjin review it
> Remoting invoke callback shoule be invoked in an executor rather than in
> current thread.
> -----------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-14
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-14
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Jaskey Lam
> Assignee: vongosling
> Priority: Minor
>
> For success callback, processResponseCommand will execute invoke callback in
> a saparate executor rather than the time thread.
> But for timeout problem , the timeout callback will be invoked directly in
> timer thread/netty selector thread.
> If the user put some time-cost task when timeout, the other timeout callback
> will be blocked to schedule.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
