[
https://issues.apache.org/jira/browse/ROCKETMQ-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784682#comment-15784682
]
ASF GitHub Bot commented on ROCKETMQ-16:
----------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/15
> Improve the codes of setting topic.json's and subscriptionGroup.json's path
> ---------------------------------------------------------------------------
>
> Key: ROCKETMQ-16
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-16
> Project: Apache RocketMQ
> Issue Type: Improvement
> Affects Versions: 4.0.0-incubating
> Reporter: ZhangKe
> Assignee: vongosling
> Priority: Minor
> Fix For: 4.0.0-incubating
>
>
> Take TopicConfigManager#configFilePath() for example:
> public String configFilePath() {
> // return
> BrokerPathConfigHelper.getTopicConfigPath(this.brokerController.getMessageStoreConfig()
> // .getStorePathRootDir());
> return
> BrokerPathConfigHelper.getTopicConfigPath(System.getProperty("user.home") +
> File.separator + "store");
> }
>
> As far as I know, the designers of RMQ want to separate topic.json and
> subscriptionGroup.json(I call them static config files) from store files to
> make spreading easily(copy them to a new broker directly). So putting them to
> another dir is reasonable, but we can do it more graceful.
> At the same time, I add a property named staticConfigFileRootDir in
> MessageStoreConfig to make their's dir configurable. By default,
> staticConfigFileRootDir equals storePathRootDir.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
