[jira] [Commented] (ROCKETMQ-5) Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent()

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784866#comment-15784866
 ] 

ASF GitHub Bot commented on ROCKETMQ-5:
---------------------------------------

GitHub user shroman opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/23

    [ROCKETMQ-5] Avoid creating directories in UtilAll#getDiskPartitionSp…

    …aceUsedPercent()
    
    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-5

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shroman/incubator-rocketmq ROCKETMQ-5

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit 8d78c7313ccbf7a38fc0d61e44a32cd13dc5f462
Author: shroman <rsht...@yahoo.com>
Date:   2016-12-29T08:37:15Z

    [ROCKETMQ-5] Avoid creating directories in 
UtilAll#getDiskPartitionSpaceUsedPercent()
    
    JIRA issue: https://issues.apache.org/jira/browse/ROCKETMQ-5

----


> Avoid creating directories in UtilAll#getDiskPartitionSpaceUsedPercent()
> ------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-5
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-5
>             Project: Apache RocketMQ
>          Issue Type: Bug
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> Since {{UtilAll#getDiskPartitionSpaceUsedPercent()}} is a diagnostic method, 
> rather than creating a directory if it is not found, produce an error log 
> that the directory is supposed to exist and return {{-1}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)