[
https://issues.apache.org/jira/browse/ROCKETMQ-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817600#comment-15817600
]
ASF GitHub Bot commented on ROCKETMQ-43:
----------------------------------------
GitHub user wu-sheng opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/36
[ROCKETMQ-43] Remove NoWhitespaceBefore module in “rmq_checkstyle.xml”
There are both NoWhitespaceBefore and WhitespaceAfter modules in
checkstyle.xml, like this:
<module name="NoWhitespaceBefore"/>
<module name="WhitespaceAfter"/>
ref https://issues.apache.org/jira/browse/ROCKETMQ-43
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wu-sheng/incubator-rocketmq fix/ROCKETMQ-43
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/36.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #36
----
commit 30bbee67d030c3d0910be773beb3eb1578ac4644
Author: wusheng <[email protected]>
Date: 2017-01-11T08:04:06Z
ROCKETMQ-43: remove NoWhitespaceBefore module in “rmq_checkstyle.xml”
----
> code style file didn't match check-style in typecast
> ----------------------------------------------------
>
> Key: ROCKETMQ-43
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-43
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Wu Sheng
> Assignee: vongosling
> Priority: Critical
>
> I have already add RocketMQ's style file, and use IntelliJ to format file,
> still fail on style-check like this:
> [INFO] Starting audit...
> /home/travis/build/wu-sheng/incubator-rocketmq/namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java:105:47:
> error: 'typecast' is not followed by whitespace.
> In intelliJ auto-format:
> LoggerContext lc = (LoggerContext)LoggerFactory.getILoggerFactory();
> But in style-check:
> LoggerContext lc = (LoggerContext) LoggerFactory.getILoggerFactory();
> It got my crazy... when I change some classes, which include cast.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
