[jira] [Commented] (ROCKETMQ-39) Duplicated codes in both filtersrv and namesrv modules

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15832963#comment-15832963
 ] 

ASF GitHub Bot commented on ROCKETMQ-39:
----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/34
  
    
    [![Coverage 
Status](https://coveralls.io/builds/9780368/badge)](https://coveralls.io/builds/9780368)
    
    Changes Unknown when pulling **c81c912526c4daf7ca01a187e8a181e605bc1824 on 
wu-sheng:fix/ROCKETMQ-39** into ** on apache:master**.



> Duplicated codes in both filtersrv and namesrv modules
> ------------------------------------------------------
>
>                 Key: ROCKETMQ-39
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-39
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>          Components: rocketmq-namesrv
>            Reporter: Wu Sheng
>            Assignee: Xiaorui Wang
>            Priority: Minor
>
> In FiltersrvStartup.class and NamesrvStartup.class, exist the exact same code 
> about add jvm shutdown hook, and execute somthing on shutting down.
> Runtime.getRuntime().addShutdownHook(new Thread(new Runnable() {
>                 private volatile boolean hasShutdown = false;
>                 private AtomicInteger shutdownTimes = new AtomicInteger(0);
>                 @Override
>                 public void run() {
>                     synchronized (this) {
>                         log.info("shutdown hook was invoked, " + 
> this.shutdownTimes.incrementAndGet());
>                         if (!this.hasShutdown) {
>                             this.hasShutdown = true;
>                             long begineTime = System.currentTimeMillis();
>                             controller.shutdown();
>                             long consumingTimeTotal = 
> System.currentTimeMillis() - begineTime;
>                             log.info("shutdown hook over, consuming time 
> total(ms): " + consumingTimeTotal);
>                         }
>                     }
>                 }
>             }, "ShutdownHook"));



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)