[
https://issues.apache.org/jira/browse/ROCKETMQ-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853715#comment-15853715
]
yukon commented on ROCKETMQ-77:
-------------------------------
Hi, [~roman_s]
We just skip the unit tests of tools.
IMO, start a name server isn't a good idea, it could be better that mock the
connections between namesrv and tools modules, could you please polish the
unit tests of tools in next release version?
> [TEST] org.apache.rocketmq.tools.* have NPEs
> --------------------------------------------
>
> Key: ROCKETMQ-77
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-77
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-tools
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Fix For: 4.1.0-incubating
>
>
> Run {{mvn test}} and see {{org.apache.rocketmq.tools.*}} having NPEs, because
> no nameserver is started.
> This can be fixed by, for instance, having {{IntegrationTestBase}} staring a
> nameserver when tests are being run.
> In general, I would throw an exception whenever obtaining a nameserver is
> failed, rather than returning {{null}}, because a connection to the
> nameserver is a must to do any useful work in RocketMQ.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
