[
https://issues.apache.org/jira/browse/ROCKETMQ-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869252#comment-15869252
]
ASF GitHub Bot commented on ROCKETMQ-102:
-----------------------------------------
GitHub user Jaskey opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/64
[ROCKETMQ-102] When shutdown(), the persisted offet is not the latest
consumed message, which may cause repeated messages.
Solution: add interface for push consumer to accept await termination time
to await consuming.
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-102
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jaskey/incubator-rocketmq
ROCKETMQ-102-shutdown-await
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 7dd5f353eb926a6af4e9519a69077a463ea75b50
Author: Jaskey <[email protected]>
Date: 2017-02-16T05:32:40Z
[ROCKETMQ-102] When shutdown(), the persisted offet is not the latest
consumed message, which may cause repeated messages.
Add interface for push consumer to accept await termination time to await
consuming,
----
> When shutdown(), the persisted offet is not the latest consumed message,
> which may cause repeated messages
> ----------------------------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-102
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-102
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Xiaorui Wang
>
> When shutdown push consumer, push consumer will shutdwon thread pool then
> persist offset.
> While shutdown thread pool is only stop submiting message to consume, which
> does not stop consuming message which exists in the the thread queue or is
> already being consumed.
> Which will cause repeated message very easily though user are shutdown
> gracefully according to the provided interface.
> A way to solve this problem is needed. Such as accpet a param that how long
> to wait for thread pool to terminated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
